Re: [Xen-devel] [PATCH RFC OSSTEST v1 09/12] mfi-common: Set diversion for build & test host install

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-01-08 at 14:29 +0000, Ian Campbell wrote:
> This means that bisections will use the same version, even if
> production-config changed in the mean time.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
> Âmfi-common | 12 ++++++++++--
> Â1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/mfi-common b/mfi-common
> index 44e7b3e..c1c4ec5 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -123,7 +123,11 @@ create_build_jobs () {
> ÂÂÂÂÂÂÂÂÂlocal suite=`getconfig DebianSuite`
> ÂÂÂÂÂfi
> Â
> -ÂÂÂÂhostos_runvars="all_host_suite=$suite"
> +ÂÂÂÂif [ -z "$diversion" ] ; then
> +ÂÂÂÂÂÂÂÂlocal diversion=`getconfig TftpDiVersion`
> +ÂÂÂÂfi

Having dropped "05/12] make-*flight: Abolish $defsuite and $guestdefsuite"
it now looks odd to define $diversion here like this.

Would it be preferable to do
        def_di_version=`getconfig TftpDiVersion`
in make-*flight and treat this like suite=$defsuite etc do you think?

Also, I was considering moving:
    defsuite=`getconfig DebianSuite`
    defguestsuite=`getconfig GuestDebianSuite`
from make-*flight to mfi-common as:
 Â: ${defsuite:=`getconfig DebianSuite`}
 Â: ${defguestsuite:=`getconfig GuestDebianSuite`}
and putting def_di_version (and likely def_guest_di_version) there too.

Do you think this is a good idea? It would mean mfi-common now sets
variables whereas today it only exports functions, I don't think that is a
problem though.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel