Re: [Xen-devel] [PATCH v6 1/5] build: Env var to enable expert config options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.01.16 at 18:33, <jonathan.creekmore@xxxxxxxxx> wrote:

>> On Jan 15, 2016, at 11:20 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> 
>>>>> On 15.01.16 at 18:01, <jonathan.creekmore@xxxxxxxxx> wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -11,6 +11,7 @@ export XEN_DOMAIN ?= $(shell ([ -x /bin/dnsdomainname ] 
>>> && 
> /bin/dnsdomainname) |
>>> export XEN_BUILD_DATE       ?= $(shell LC_ALL=C date)
>>> export XEN_BUILD_TIME       ?= $(shell LC_ALL=C date +%T)
>>> export XEN_BUILD_HOST       ?= $(shell hostname)
>>> +export XEN_CONFIG_EXPERT ?= n
>> 
>> This, I'm afraid, invalidates what I've said in another reply on
>> the earlier thread a few minutes ago. What Makefile.kconfig
>> gets to see must be consistent for FORCE to not be added to
>> include/config/auto.conf's dependencies by auto.conf.cmd.
>> 
>> Or in other words - did you check (in conjunction with that other
>> patch fixing incremental rebuilds) whether incremental rebuilds
>> aren't again becoming full rebuilds because of this when there's
>> no XEN_CONFIG_EXPERT in the environment?
> 
> I have applied your patch on top of my branch and I do not see incremental 
> rebuilds becoming full rebuilds whether XEN_CONFIG_EXPERT is not in the
> environment.

Thanks; indeed I've meanwhile realized that the "export" here
should be taking care of avoiding that situation

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel