[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 6/7] vmx: VT-d posted-interrupt core logic handling



>>> On 18.01.16 at 09:45, <feng.wu@xxxxxxxxx> wrote:
> It has been pending for such a long time, and Dario and Kevin both reviewed
> it, it is pending on your comments, could you tell when you will look at it?

I can't really, and I don't think I've seen e.g. Dario give his
Reviewed-by. This is a complicated topic, which I need sufficient
time (in a single piece) to look into (I had, btw, planned to get to
this today, but just like in so many earlier cases there may again
end up being reasons why I won't make it there). In any event
I view bug fixes (creation as well as review thereof) taking
priority over review of new feature additions, and the next thing
in the order are patches that can be expected to not take as much
time to create/review (yielding the overall better throughput).

I hate to repeat myself, but the best thing to help forward
progress here is for all of you sending out larger changes to the
hypervisor to also help with other patch review (which, perhaps
not in this particular case anymore - since the series has meanwhile
undergone quite a few iterations - but in general, includes for
everyone to look critically at their own patches, as many review
comments could be avoided by doing so). Which, btw, would
also benefit all of you, as it will inevitably lead to a better
understanding of the overall hypervisor code, (hopefully)
ultimately leading to fewer iterations on future patch series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.