Re: [Xen-devel] [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.16 at 17:33, <roger.pau@xxxxxxxxxx> wrote:
> El 18/01/16 a les 17.24, Jan Beulich ha escrit:
>> ULL might not be supported by pre-C99 compilers. Casting to
>> uint64_t is, well, ugly. The flags field really has no business
>> being wider then 32 bits.
> 
> Right, although Xen uses gnu99 this is a public header.
> 
> You should see a v3 somewhere with a proper check for the padding filed.

Thanks.

> While doing this I've also realised that the padding fields in the other
> structs in the same file don't seem to be checked at all.

For ones which already went out in a release we may not be able to
do anything retroactively.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel