Re: [Xen-devel] [PATCH OSSTEST] sg-report-job-history: alternate color of osstest column only when it changes

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2016-01-06 at 11:08 +0000, Ian Campbell wrote:

ping?

> Currently the bgcolor of the osstest column alternates on each line,
> rather than only when it changes as the other revision columns do.
> 
> A given flight might touch multiple osstest revisions (although in
> practice they rarely do) but it seems reasonable to simply consider
> any change as a change.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
> Âsg-report-job-history | 10 +++++-----
> Â1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sg-report-job-history b/sg-report-job-history
> index 0e2a3f9..e2e5806 100755
> --- a/sg-report-job-history
> +++ b/sg-report-job-history
> @@ -234,6 +234,7 @@ END
> ÂÂÂÂÂÂÂÂÂmy @last_revs;
> ÂÂÂÂÂÂÂÂÂmy @alt_revs;
> ÂÂÂÂÂÂÂÂÂmy $alt_hosts;
> +ÂÂÂÂÂÂÂÂmy $alt_osstest;
> ÂÂÂÂÂÂÂÂÂforeach my $r (@test_rows) {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂmy $altcolour= report_altcolour($alternate);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂprint H "<tr $altcolour>";
> @@ -254,16 +255,15 @@ END
> ÂÂÂÂÂÂÂÂÂÂÂÂÂmy $hosts_colour = report_altchangecolour(\$alt_hosts,
> $hosts);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂprint H "<td
> $hosts_colour>".encode_entities($hosts)."</td>\n";
> ÂÂÂÂÂÂÂÂÂÂÂÂÂ$osstestverq->execute($r->{Flight}{flight});
> -ÂÂÂÂÂÂÂÂÂÂÂÂprint H
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ"<td>",
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(join ' ',
> +ÂÂÂÂÂÂÂÂÂÂÂÂmy $osstestrevs = join ' ',
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmap {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ$_ = $_->{harness};
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂs/^([0-9a-f]{12})[0-9a-f]+\b/$1/;
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ"<kbd>".encode_entities($_)."</kbd>";
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ@{ $osstestverq->fetchall_arrayref({}) }),
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ"</td>\n";
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ@{ $osstestverq->fetchall_arrayref({}) };
> +ÂÂÂÂÂÂÂÂÂÂÂÂmy $osstest_colour = report_altchangecolour(\$alt_osstest,
> $osstestrevs);
> +ÂÂÂÂÂÂÂÂÂÂÂÂprint H "<td $osstest_colour>$osstestrevs</td>\n";
> ÂÂÂÂÂÂÂÂÂÂÂÂÂforeach my $i (0..$#rev_grid_cols) {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmy $v= $r->{Revisions}[$i];
> Â             my $rev_colour = report_altchangecolour(\$alt_revs[$i],
> $v);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel