Re: [Xen-devel] [PATCH] x86: Convert shadow-paging to Kconfig

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/16 13:27, Jan Beulich wrote:
>>>> On 18.01.16 at 19:40, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/mm/shadow/Makefile
>> +++ b/xen/arch/x86/mm/shadow/Makefile
>> @@ -1,4 +1,4 @@
>> -ifeq ($(shadow-paging),y)
>> +ifdef CONFIG_SHADOW_PAGING
>>  obj-y += common.o guest_2.o guest_3.o guest_4.o
>>  else
>>  obj-y += none.o
> Why didn't you retain the ifeq? The way it's now, accidental
> definition of the macro elsewhere would alter behavior. In fact
> I think the better thing here would be to change this to purely
> list model:
>
> obj-y := none.o
> obj-$(CONFIG_SHADOW_PAGING) := common.o guest_2.o guest_3.o guest_4.o
>
> Not sure why I didn't do that right when making this configurable...

none.o must not be linked if !CONFIG_SHADOW_PAGING.

It was cleanest to retain the existing structure.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel