Re: [Xen-devel] [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v2 5/5] libxl: Add explicit cast to 
libxl_psr_cat_set_cbm"):
> On Tue, 2016-01-19 at 14:06 +0000, Ian Jackson wrote:
> >  * XEN_DOMCTL_PSR_CAT_OP_SET_L3_* (public/domctl.h)
> >  * enum xc_psr_cat_type (xenctrl.h)
> >  * Enumeration("psr_cbm_type",...) (libxl_types.idl)
> 
> Forgot to say in my other reply, but we could try and abolish at least the
> xc one and have libxl internally use the domctl values.

Yes.

I like George's IDL suggestion.

> I should also have said I think all of this is a bit much to ask Chester to
> tackle given that the intro[0] explains that the Coverity stuff is just in
> order to gain some familiarity before embarking on a "proper" project.

Well, quite!  Sorry to Chester for having suddenly revealed this
apparently-simple bug to be a swamp.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel