Re: [Xen-devel] [PATCH] libxl: add basic spice support for pv domUs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2016-01-13 at 11:47 +0100, Fabio Fantoni wrote:
> > > Â =head2 Keymaps
> > > Â 
> > > Â The keymaps available are defined by the device-model which you are
> > > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > > index 6b73848..a5cbcfc 100644
> > > --- a/tools/libxl/libxl.h
> > > +++ b/tools/libxl/libxl.h
> > > @@ -510,6 +510,19 @@ typedef struct libxl__ctx libxl_ctx;
> > > Â #define LIBXL_HAVE_BUILDINFO_USBVERSION 1
> > > Â 
> > > Â /*
> > > + * LIBXL_HAVE_BUILDINFO_SPICE
> > > + *
> > > + * If this is defined, then the libxl_domain_build_info structure
> > > will
> > > + * contain spice, a libxl_spice_info struct instead of older
> > > hvm.spice one
> > > + * which is now deprecated.
> > > + *
> > This reads like hvm.spice is removed but I think hvm.spice still
> > exists.
> 
> Yes I keeped hvm.spice (as "duplicate") for compatibility as suggested 
> by someone long time ago.

Saying "is used in preference to", rather than "instead of" in the comment
would express this better since "instead" implies replacing, not just
adding a newer interface).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel