Re: [Xen-devel] [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2016-01-25 at 12:31 +0000, Ian Campbell wrote:
> On Mon, 2016-01-25 at 13:01 +0100, Olaf Hering wrote:
> > On Fri, Jan 15, Ian Campbell wrote:
> > 
> > > libxenforeignmemory will provide a stable API and ABI for mapping
> > > foreign domain memory (subject to appropriate privileges).
> > 
> > I think this will break my Xen pkg build:
> > 
> > [ÂÂ333s] kdd-xen.c: In function 'kdd_access_physical_page':
> > [ÂÂ333s] kdd-xen.c:508:15: warning: implicit declaration of function
> > 'xc_map_foreign_range' [-Wimplicit-function-declaration]
> > [ÂÂ333s]ÂÂÂÂÂÂÂÂÂÂmap = xc_map_foreign_range(g->xc_handle,
> > [ÂÂ333s]ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> > [ÂÂ333s] kdd-xen.c:508:13: warning: assignment makes pointer from
> > integer
> > without a cast [-Wint-conversion]
> > [ÂÂ333s]ÂÂÂÂÂÂÂÂÂÂmap = xc_map_foreign_range(g->xc_handle,
> > [ÂÂ333s]ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> 
> I supposed this wasn't built by default and I missed it, but it looks to be
> built unconditionally. I wonder why I didn't see this.

Turns out this code doesn't use Werror, so it was failing but was lost in
the noise (e.g. you can find it inÂhttp://logs.test-lab.xenproject.org/osst
est/logs/78820/build-amd64/5.ts-xen-build.log)

> Defining XC_WANT_COMPAT_MAP_FOREIGN_API while building is one way to fix,
> or else kdd would need to switch to the new interface. The latter is
> obviously better long term, but the former is done for a bunch of stuff in
> tree so it might as well be done here too.
> 
> The machine with the trees I used for this work is currently unavailable
> (network issues in our office), but I'll see if I can reproduce.

I did, I'll send a patch taking the easy way out as a reply.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel