[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Reset runstate_guest handles on soft reset



>>> On 28.01.16 at 10:34, <vkuznets@xxxxxxxxxx> wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1074,7 +1074,10 @@ int domain_soft_reset(struct domain *d)
>      grant_table_warn_active_grants(d);
>  
>      for_each_vcpu ( d, v )
> +    {
> +        memset(&runstate_guest(v), 0, sizeof(runstate_guest(v)));
>          unmap_vcpu_info(v);
> +    }

Well, the idea seems okay, but using memset() looks bogus: Why
can't you use guest_handle_from_pointer(NULL, ...) or
set_xen_guest_handle(..., NULL)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.