Re: [Xen-devel] [PATCH 2/4] x86: adjust xsave structure attributes

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/01/16 10:27, Jan Beulich wrote:
> The packed attribute was pointlessly used here - there are no
> misaligned fields, and hence even if the attribute took effect, it
> would at best lead to the compiler generating worse code.
>
> At the same time specify the required alignment of the fpu_sse sub-
> structure, such that the various typeof() uses on that field obtain
> pointers to properly aligned memory (knowledge which a compiler may
> want to make use of).
>
> Also add suitable build-time checks.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel