Re: [Xen-devel] [PATCH v7 03/22] arm/acpi: Add __acpi_map_table function for ARM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.02.16 at 21:29, <zhaoshenglong@xxxxxxxxxx> wrote:
> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> ---
> v7: fix coding style

Thanks, almost (see below).

> --- /dev/null
> +++ b/xen/arch/arm/acpi/lib.c
> @@ -0,0 +1,53 @@
> +/*
> + *  lib.c - Architecture-Specific Low-Level ACPI Support
> + *
> + *  Copyright (C) 2015, Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> + *
> + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, write to the Free Software
> + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

I'm sorry for noticing only now, but iirc a while ago there was a huge
commit removing these addresses from source files. See the x86
counterpart of this file for how the header is expected to look like
now.

> + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> + */
> +
> +#include <xen/acpi.h>
> +#include <xen/mm.h>
> +#include <asm/config.h>
> +
> +char *__acpi_map_table(paddr_t phys, unsigned long size)
> +{
> +    unsigned long base, offset, mapped_size;
> +    int idx;
> +
> +    offset = phys & (PAGE_SIZE - 1);
> +    mapped_size = PAGE_SIZE - offset;
> +    set_fixmap(FIXMAP_ACPI_BEGIN, phys >> PAGE_SHIFT, PAGE_HYPERVISOR);
> +    base = FIXMAP_ADDR(FIXMAP_ACPI_BEGIN);
> +
> +    /*
> +     * Most cases can be covered by the below.
> +     */

According to our style this is to be a single line comment.

Also please note that especially for larger series sending individual
patch updates is sub-optimal: I'm not going to invest much time to
try and track which patch of a series at which version is ready to
go in. When a full series is submitted, initial parts that are ready
or become ready by receiving the necessary ack-s will get applied.
Anything past the first patch in the series that needs an update
will get dropped, unless it was clearly and explicitly said that some
patch can be applied out of order. Collecting things in a
piecemeal manner (like what would result if this patch was now
ready to go in) is just too time consuming.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel