Re: [Xen-devel] [PATCH v3 13/16] hvmloader: Load ACPI tables from hvm_start_info module

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.02.16 at 15:56, <anthony.perard@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/hvmloader.c
> +++ b/tools/firmware/hvmloader/hvmloader.c
> @@ -365,8 +365,26 @@ int main(void)
>  
>          if ( bios->acpi_build_tables )
>          {
> +            const struct hvm_modlist_entry *acpi_module;
> +            acpi_module = get_module_entry(hvm_start_info, "acpi");
>              printf("Loading ACPI ...\n");
> -            bios->acpi_build_tables();
> +            if ( acpi_module )
> +            {
> +                uint32_t paddr = acpi_module->paddr;
> +                bios->acpi_build_tables((void*)paddr,
> +                                        acpi_module->size);
> +            }

Hmm, so far it was the build process which ensured the right ACPI
tables would be used with the corresponding BIOS. The disconnect
that gets introduced here worries me a little, since things having
got out of sync may be rather hard to diagnose (as they may
surface only much later).

> +#ifdef ENABLE_ROMBIOS
> +            else if ( bios == &rombios_config )
> +            {
> +                bios->acpi_build_tables(0, 0);
> +            }
> +#endif
> +            else
> +            {
> +                printf("no ACPI DSDT image found\n");
> +                BUG();
> +            }

Is this really fatal? It's not like "no ACPI" == "end of the world",
is it?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel