Re: [Xen-devel] [PATCH v5] libelf: rewrite symtab/strtab loading

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.03.16 at 19:25, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Roger Pau Monne writes ("[PATCH v5] libelf: rewrite symtab/strtab loading"):
>> Current implementation of elf_load_bsdsyms is broken when loading inside of
>> a HVM guest, because it assumes elf_memcpy_safe is able to write into guest
>> memory space, which it is not.
>> 
>> Take the oportunity to do some cleanup and properly document how
>> elf_{parse/load}_bsdsyms works. The new implementation uses elf_load_image
>> when dealing with data that needs to be copied to the guest memory space.
>> Also reduce the number of section headers copied to the minimum necessary.
>> 
>> This patch also removes the duplication of code found in the libxc ELF
>> loader, since the libelf symtab/strtab loading code will also handle this
>> case without having to duplicate it.
> 
> I haven't checked this for correctness.  This symtab/strtab stuff is
> for the benefit of BSD and I trust you to have checked that it works
> :-).
> 
> I have however checked that your new code seems to follow the
> conventions in libelf.h which are intended to stop wild pointer
> accesses, signed integer overflow, and other UB.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Jan, or other HV folks, do you want to review/ack this or shall I just
> commit it ?

I'd like to take another look, after my review on v4.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel