[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 12/31] tools/libxl: add back channel support to read stream



On Fri, Feb 26, 2016 at 10:16:43AM +0800, Wen Congyang wrote:
[...]
> > 
> > Even if it doesn't have restore helper, check_all_finished also checks
> > if the stream and the conversion helper are till in use.  The
> > explanation in the comment doesn't seem to justify this change.
> 
> In stream_done(), stream->running is set to false, so 
> libxl__stream_read_in_use()
> returns false.
> 
> Back channel stream doesn't support legacy stream, so there is no conversion 
> helper.
> 
> I will update the comments in the next version.
> 

Yes, please do. Say clearly why it is not needed.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.