Re: [Xen-devel] [PATCH v10 31/31] cmdline switches and config vars to control colo-proxy

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

On 03/02/2016 11:05 PM, Wei Liu wrote:
> On Mon, Feb 22, 2016 at 10:52:35AM +0800, Wen Congyang wrote:
>> Add cmdline switches to 'xl migrate-receive' command to specify
>> a domain-specific hotplug script to setup COLO proxy.
>>
>> Add a new config var 'colo.default.agentscript' to xl.conf, that
>> allows the user to override the default global script used to
>> setup COLO proxy.
>>
>> Signed-off-by: Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
>> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
>> ---
>>  docs/man/xl.conf.pod.5      |  6 ++++++
>>  docs/man/xl.pod.1           |  1 -
>>  tools/libxl/libxl.c         |  6 ++++++
>>  tools/libxl/libxl_create.c  | 14 ++++++++++++--
>>  tools/libxl/libxl_types.idl |  1 +
>>  tools/libxl/xl.c            |  3 +++
>>  tools/libxl/xl.h            |  1 +
>>  tools/libxl/xl_cmdimpl.c    | 47 
>> ++++++++++++++++++++++++++++++++++-----------
>>  8 files changed, 65 insertions(+), 14 deletions(-)
>>
>> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
>> index 8ae19bb..8f7fd28 100644
>> --- a/docs/man/xl.conf.pod.5
>> +++ b/docs/man/xl.conf.pod.5
>> @@ -111,6 +111,12 @@ Configures the default script used by Remus to setup 
>> network buffering.
>>  
>>  Default: C</etc/xen/scripts/remus-netbuf-setup>
>>  
>> +=item B<colo.default.proxyscript="PATH">
>> +
>> +Configures the default script used by COLO to setup colo-proxy.
>> +
>> +Default: C</etc/xen/scripts/colo-proxy-setup>
>> +
>>  =item B<output_format="json|sxp">
>>  
>>  Configures the default output format used by xl when printing "machine
>> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
>> index 4f1901d..edeafcf 100644
>> --- a/docs/man/xl.pod.1
>> +++ b/docs/man/xl.pod.1
>> @@ -454,7 +454,6 @@ N.B: Remus support in xl is still in experimental 
>> (proof-of-concept) phase.
>>       Disk replication support is limited to DRBD disks.
>>  
>>       COLO support in xl is still in experimental (proof-of-concept) phase.
>> -     There is no support for network at the moment.
> 
> 
> Same here, missing documentation on how to use the new parameters (if
> any). Please provide adequate documentation otherwise we can't
> meaningfully review the rest of this patch.

OK, will fix it in the next version.

Thanks
Wen Congyang

> 
> Wei.
> 
> 
> .
> 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel