[Xen-devel] [PATCH V2] libxc: Have xc_translate_foreign_address() set errno properly

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

Fixes https://jira.bitdefender.biz/browse/HEIMDALL-71
Roughly based on Don Slutz' patch:
http://lists.xen.org/archives/html/xen-devel/2014-03/msg03720.html

Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

---
Changes since V1:
 - Turns out that the only case that has occured in my tests where
   errno is not set is the "if (!(pte & 1))" case. Removed all
   other errno checks.
---
 tools/libxc/xc_pagetab.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/libxc/xc_pagetab.c b/tools/libxc/xc_pagetab.c
index ec97890..92eebd6 100644
--- a/tools/libxc/xc_pagetab.c
+++ b/tools/libxc/xc_pagetab.c
@@ -88,8 +88,10 @@ unsigned long xc_translate_foreign_address(xc_interface 
*xch, uint32_t dom,
             return 0;
         memcpy(&pte, map + (paddr & (PAGE_SIZE - 1)), size);
         munmap(map, PAGE_SIZE);
-        if (!(pte & 1)) 
+        if (!(pte & 1)) {
+            errno = EADDRNOTAVAIL;
             return 0;
+        }
         paddr = pte & 0x000ffffffffff000ull;
         if (level == 2 && (pte & PTE_PSE)) {
             mask = ((mask ^ ~-mask) >> 1); /* All bits below first set bit */
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel