Re: [Xen-devel] [PATCH v3 10/16] hvmloader: Load SeaBIOS from hvm_start_info modules

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Feb 29, 2016 at 10:02:10AM -0700, Jan Beulich wrote:
> >>> On 25.02.16 at 15:56, <anthony.perard@xxxxxxxxxx> wrote:
> > @@ -127,22 +124,29 @@ static void seabios_setup_e820(void)
> >      struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0);
> >      info->e820 = (uint32_t)e820;
> >  
> > +    BUG_ON(seabios_config.bios_address == 0);
> 
> I think this is too lax: Surely this shouldn't live below 0xC0000
> nor above 0x100000?

I was just trying to check that seabios_load() was called before this one.
But I guest it does not hurt to expand the assertion.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel