Re: [Xen-devel] [PATCH v5 22/22] xen/arm64: Add ACPI support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.03.16 at 07:15, <zhaoshenglong@xxxxxxxxxx> wrote:
> From: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
> 
> Add ACPI support on arm64 xen hypervisor. Enable EFI support on ARM.
> 
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> ---
> v5: make ACPI selectable option
> ---
>  xen/arch/arm/Kconfig         |  9 +++++++++
>  xen/common/efi/runtime.c     | 12 +++++++-----

For the change to this file:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
However ...

> +++ b/xen/arch/arm/Kconfig
> @@ -33,6 +33,15 @@ menu "Architecture Features"
>  
>  source "arch/Kconfig"
>  
> +config ACPI
> +     bool "ACPI (Advanced Configuration and Power Interface) Support"
> +     depends on ARM_64
> +     default y

... I recall Stefano having asked for this, but - are both of you sure?
Have you seen the earlier discussion about the introduction of new
user selectable config options? I.e. shouldn't the prompt at least
become conditional on EXPERT = "y", just like done elsewhere?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel