Re: [Xen-devel] [PATCH v5 02/22] arm/acpi: Add a helper function to get the acpi table offset

[Shannon Zhao <shannon.zhao@xxxxxxxxxx>]

On 2016年03月04日 18:59, Stefano Stabellini wrote:
>> diff --git a/xen/include/asm-arm/acpi.h b/xen/include/asm-arm/acpi.h
>> > index 7f59761..6db3711 100644
>> > --- a/xen/include/asm-arm/acpi.h
>> > +++ b/xen/include/asm-arm/acpi.h
>> > @@ -25,6 +25,7 @@
>> >  
>> >  #include <xen/init.h>
>> >  #include <asm/page.h>
>> > +#include <asm/setup.h>
>> >  
>> >  #define COMPILER_DEPENDENT_INT64   long long
>> >  #define COMPILER_DEPENDENT_UINT64  unsigned long long
>> > @@ -58,10 +59,15 @@ static inline void enable_acpi(void)
>> >  {
>> >      acpi_disabled = 0;
>> >  }
>> > +
>> > +paddr_t acpi_get_table_offset(struct membank tbl_add[], EFI_MEM_RES 
>> > index);
>> >  #else
>> >  #define acpi_disabled (1)
>> >  #define disable_acpi()
>> >  #define enable_acpi()
>> > +paddr_t inline acpi_get_table_offset(struct membank tbl_add[],
>> > +                                     EFI_MEM_RES index)
>> > +{ return 0; }
> Why did you move the declaration of acpi_get_table_offset to within the
> ifdef?  It was just above the ifdef in the previous version of the
> patch.
> 
If we don't do this, when we compile Xen just only apply the first 11
patches of this series and since the acpi_create_efi_system_table is not
covered by #ifdef CONFIG_ACPI, it will throw out an error says something
like "acpi_get_table_offset not defined".

Thanks,
-- 
Shannon

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel