Re: [Xen-devel] [PATCH] libxc: move migration_stream's definition to xenguest.h

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/03/16 05:32, Wen Congyang wrote:
> xc_save_domain()'s parameter use this type, so it should
> be public.

xc_domain_save() currently uses an int, which also needs fixing.

>
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>

Does this even compile?  You have removed a variable without any
replacement.

> ---
>  tools/libxc/include/xenguest.h | 10 ++++++++++
>  tools/libxc/xc_sr_common.h     | 10 ----------
>  2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tools/libxc/include/xenguest.h b/tools/libxc/include/xenguest.h
> index affc42b..888536e 100644
> --- a/tools/libxc/include/xenguest.h
> +++ b/tools/libxc/include/xenguest.h
> @@ -238,4 +238,9 @@ xen_pfn_t *xc_map_m2p(xc_interface *xch,
>                        unsigned long max_mfn,
>                        int prot,
>                        unsigned long *mfn0);
> +
> +typedef enum {
> +    MIG_STREAM_NONE, /* plain stream */
> +    MIG_STREAM_REMUS,
> +} migration_stream;

This typedef should be beside xc_domain_save() as that is where it is
intended to be used.  It also needs xc_ prefixes as it is part of the
public interface, and a typedef wants a _t suffix.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel