Re: [Xen-devel] [PATCH v11 07/27] docs/libxl: Introduce CHECKPOINT_CONTEXT to support migration v2 colo streams

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 04, 2016 at 04:51:20PM +0000, Ian Jackson wrote:
[...]
> 
> > @@ -212,6 +214,11 @@ class VerifyLibxl(VerifyBase):
> >          if len(content) != 0:
> >              raise RecordError("Checkpoint end record with non-zero length")
> >  
> > +    def verify_record_checkpoint_state(self, content):
> > +        """ Checkpoint state """
> > +        if len(content) == 0:
> > +            raise RecordError("Checkpoint state record with zero length")
> > +
> 
> I'm not verify familiar with this area of the code, but I think that
> this should probably check that the control_id is as expected.  Can it
> know what the right sequencing is ?
> 

FWIW this script is not used in live system -- so it probably doesn't
have information on the control id and the sequence on a live system.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel