Re: [Xen-devel] [PATCH v6 for Xen 4.7 2/4] libxc: enable per-VCPU parameter settings for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Tue, Mar 8, 2016 at 1:09 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Sun, Mar 06, 2016 at 11:55:56AM -0600, Chong Li wrote:
>> Add xc_sched_rtds_vcpu_get/set functions to interact with
>> Xen to get/set a domain's per-VCPU parameters.
>>
>> Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
>> Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
>> Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
>>
>> ---
>> Changes on PATCH v5:
>> 1) In xc_sched_rtds_vcpu_get/set, re-issueing the hypercall
>> if it is preempted.
>>
>> Changes on PATCH v4:
>> 1) Minor modifications on the function parameters.
>>
>> Changes on PATCH v2:
>> 1) Minor modifications due to the change of struct xen_domctl_scheduler_op.
>>
>> CC: <dario.faggioli@xxxxxxxxxx>
>> CC: <george.dunlap@xxxxxxxxxxxxx>
>> CC: <dgolomb@xxxxxxxxxxxxxx>
>> CC: <mengxu@xxxxxxxxxxxxx>
>> CC: <wei.liu2@xxxxxxxxxx>
>> CC: <lichong659@xxxxxxxxx>
>> ---
>>  tools/libxc/include/xenctrl.h | 16 +++++++---
>>  tools/libxc/xc_rt.c           | 68 
>> +++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 80 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
>> index 01a6dda..9462271 100644
>> --- a/tools/libxc/include/xenctrl.h
>> +++ b/tools/libxc/include/xenctrl.h
>> @@ -888,11 +888,19 @@ int xc_sched_credit2_domain_get(xc_interface *xch,
>>                                 struct xen_domctl_sched_credit2 *sdom);
>>
>>  int xc_sched_rtds_domain_set(xc_interface *xch,
>> -                            uint32_t domid,
>> -                            struct xen_domctl_sched_rtds *sdom);
>> +                               uint32_t domid,
>> +                               struct xen_domctl_sched_rtds *sdom);
>>  int xc_sched_rtds_domain_get(xc_interface *xch,
>> -                            uint32_t domid,
>> -                            struct xen_domctl_sched_rtds *sdom);
>> +                               uint32_t domid,
>> +                               struct xen_domctl_sched_rtds *sdom);
>
> Please don't mix fixing indentation with new functionality. Besides, the
> new indentation looks wrong.
>
>> +int xc_sched_rtds_vcpu_set(xc_interface *xch,
>> +                               uint32_t domid,
>> +                               struct xen_domctl_schedparam_vcpu *vcpus,
>> +                               uint32_t num_vcpus);
>> +int xc_sched_rtds_vcpu_get(xc_interface *xch,
>> +                               uint32_t domid,
>> +                               struct xen_domctl_schedparam_vcpu *vcpus,
>> +                               uint32_t num_vcpus);
>>
>
> Indentation also looks wrong. Maybe you used tab? Please use spaces
> instead.
>
I'm not using tab. This is just what I'm confused with. The
indentation for these
four *rtds* functions is the same as the two *credit2* functions
above. I can not
find the indentation rules for function calls with many / long parameters.

Chong

-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel