Re: [Xen-devel] [PATCH v6 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On the whole series, you are Cc-ing ian.campbell@xxxxxxxxxxxxx, which
is no longer a tools maintainer.

Please, double check by looking at MAINTAINERS and/or with
./scripts/get_maintainer.pl.

While fiddling with the Cc-list, can you please try to arrange things
in such a way that each person is Cc-ed only to the subset of the
series that he would reasonably care about.

For instance, Jan is likely not going to look at libxl and xl stuff, so
no need bothering him with that. Similarly, IanJ wouldn't probably look
at hypervisor stuff.

If you are in doubt, stick to MAINTAINERS, with the exception that, if
some random person commented on vX, he should be Cc-ed to vX+1, where
the comments are addressed, no matter what he/she maintains.

There are other exceptions, actually. For example, it's ok to Cc me to
the whole series. This is hard to "set in stone", so again, if in
doubt, follow the rule above... If people are interested in a patch
that they happen not to be Cc-ed to, they'll find it via the mailing
list.

On Sun, 2016-03-06 at 11:55 -0600, Chong Li wrote:
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index bd3aac8..4532e86 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -5770,6 +5770,207 @@ static int sched_credit2_domain_set(libxl__gc
> *gc, uint32_t domid,
>      return 0;
>  }
>  
> +static int sched_rtds_validate_params(libxl__gc *gc, int period,
> +                                    int budget, uint32_t
> *sdom_period,
> +                                    uint32_t *sdom_budget)
> +{
> +    int rc = 0;
>
Empty line here (between local variables and code).

Also, libxl coding style says:

  * If the function is to return a libxl error value, `rc' is
    used to contain the error code, but it is NOT initialised:
            int rc;

This, in addition to all what Wei pointed out, to mean that, although
things are certainly improving, some non negligible amount of coding
style issues needs fixing.

(I'll elaborate more, and more in general, in another email.)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel