Re: [Xen-devel] [PATCH v2 1/2] tools/foreign: Avoid using alignment directives when not appropriate

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 10, 2016 at 01:33:16AM -0700, Jan Beulich wrote:
> >>> On 09.03.16 at 20:56, <wei.liu2@xxxxxxxxxx> wrote:
> > On Wed, Mar 09, 2016 at 07:03:15PM +0000, Andrew Cooper wrote:
> >> The foreign header generation blindly replaces 'uint64_t' with '__align8__
> >> uint64_t', to get correct alignment when built as 32bit.  This is correct 
> >> in
> >> most circumstances, but Clang objects to two specific uses.
> >> 
> >>  * Inside a sizeof() expression
> >>  * As part of a typecast
> >> 
> >> An example error looks like:
> >> 
> >> /local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:204:44:
> >> error: 'aligned' attribute ignored when parsing type 
> > [-Werror,-Wignored-attributes]
> >>     __align8__ uint64_t evtchn_mask[sizeof(__align8__ uint64_t) * 8];
> >>                                            ^~~~~~~~~~
> >> /local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:13:36:
> >> note: expanded from macro '__align8__'
> >>                                    ^~~~~~~~~~~
> >> 
> >> This sedary is sufficient to fix all the bad examples without touching any 
> > of
> >> the legitimate uses, and is more simple than teaching mkheader.py how to 
> > parse
> >> C.
> >> 
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Should I apply this and the 2nd patch, or can/should this wait
> for Ian to be back?
> 

You can go ahead if convenient.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel