Re: [Xen-devel] [PATCH 1/2] x86/shadow: compile most write emulation code just once

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/03/16 10:13, Jan Beulich wrote:
> No need to compile all of this code three times, as most of it really
> is guest mode independent. The savings are between 3k and 4k of binary
> code in my builds.
>
> No functional change (i.e. only formatting and naming changes) except
> for
> - sh_emulate_map_dest()'s user mode check corrected for the PV case
>   (affecting debugging mode only, this isn't being split out)
> - simplifying the vaddr argument to emulate_gva_to_mfn() for the second
>   part in the cross page write case
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel