[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images
- To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- From: "Vladimir 'phcoder' Serbinenko" <phcoder@xxxxxxxxx>
- Date: Fri, 11 Mar 2016 17:13:19 +0100
- Cc: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "grub-devel@xxxxxxx" <grub-devel@xxxxxxx>, "eric.snowberg@xxxxxxxxxx" <eric.snowberg@xxxxxxxxxx>, "arvidjaar@xxxxxxxxx" <arvidjaar@xxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "cardoe@xxxxxxxxxx" <cardoe@xxxxxxxxxx>, "pgnet.dev@xxxxxxxxx" <pgnet.dev@xxxxxxxxx>, "roy.franz@xxxxxxxxxx" <roy.franz@xxxxxxxxxx>, "ning.sun@xxxxxxxxx" <ning.sun@xxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "stefano.stabellini@xxxxxxxxxxxxx" <stefano.stabellini@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "qiaowei.ren@xxxxxxxxx" <qiaowei.ren@xxxxxxxxx>, "richard.l.maliszewski@xxxxxxxxx" <richard.l.maliszewski@xxxxxxxxx>, "gang.wei@xxxxxxxxx" <gang.wei@xxxxxxxxx>, "fu.wei@xxxxxxxxxx" <fu.wei@xxxxxxxxxx>, "seth.goldberg@xxxxxxxxxx" <seth.goldberg@xxxxxxxxxx>
- Delivery-date: Fri, 11 Mar 2016 16:13:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
> > + if (relocatable)
> > + {
> > + if (base_addr > min_addr)
> > + grub_multiboot_payload_eip += base_addr - min_addr;
> > + else
> > + grub_multiboot_payload_eip -= min_addr - base_addr;
> > + }
> > +
> >
> Why is it relative to min_addr? Sounds like it should be just an offset
Ugh... IIRC, it has meaning but I forgot what. I will check it.
However, this means that I must put comment here.
Is it possible that you have confused link address and minimal loading address? How is entry usually specified in ELF? How do you suggest it should be done in mb headers?
> from base addr. What do ET_DYN files use?
I will take a look.
Daniel
--
Regards
Vladimir 'phcoder' Serbinenko
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
