Re: [Xen-devel] [PATCH v6 for Xen 4.7 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.03.16 at 18:05, <lichong659@xxxxxxxxx> wrote:
> So I still keep my design here?
> 
> Dario, Jan and Wei,

Afaic:

> I almost finished a new version, but since this part is critical for
> the whole patch, let me summarize the feedbacks here. Please correct
> me if my understanding is wrong.
> 
> 1) We don't need "guest_handle_is_null()" check, because null handle
> could be used in some special cases. And normally, handle is checked
> by copy_from(to)_guest* functions.

Yes.

> 2) In domctl.h, add explain for nr_vcpus, because it is used in both
> IN and OUT ways.

Yes.

> 3) Use printk(XENLOG_G_WARNING ...) here, because of its rate limit feature.

I'd say XENLOG_G_DEBUG, and even that only if you really think
the message is useful.

> 4) Do I still keep the spin_lock inside the loop body?

I think overall that's the better alternative.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel