|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH RFC v3 00/28] x86: Improvements to cpuid handling for guests
Presented here is v3 of my work to improve cpuid levelling for guests. This series is available in git form at: http://xenbits.xen.org/git-http/people/andrewcoop/xen.git levelling-v3 Major changes from v2 include further rebasing over several newly-accepted features. There have been further bugfixes to x87 pipeline handling, and topology reporting. Also more research into feature dependency trees. This series is still RFC because I am in the process of re-testing all the issues we encountered previously, but it should be correct as-is. The current cpuid code, both in the hypervisor and toolstack, has grown organically for a very long time, and is flawed in many ways. This series focuses specifically on the fixing the bits pertaining to the visible features, and I will be fixing other areas in future work (e.g. per-core, per-package values, auditing of incoming migration values, etc.) These changes alter the workflow of cpuid handling as follows: Xen boots and evaluates its current capabilities. It uses this information to calculate the maximum featuresets it can provide to guests, and provides this information for toolstack consumption. A toolstack may then calculate a safe set of features (taking into account migratability), and sets a guests cpuid policy. Xen then takes care of context switching the levelling state. In particular, this means that PV guests may have different levels while running on the same host, an option which was not previously available. Andrew Cooper (28): xen/x86: Drop unused and non-useful feature definitions xen/x86: Rename features to be closer to the vendor definitions xen/public: Export cpu featureset information in the public API xen/x86: Script to automatically process featureset information xen/x86: Collect more cpuid feature leaves xen/x86: Mask out unknown features from Xen's capabilities xen/x86: Annotate special features xen/x86: Annotate VM applicability in featureset xen/x86: Calculate maximum host and guest featuresets xen/x86: Generate deep dependencies of features xen/x86: Clear dependent features when clearing a cpu cap xen/x86: Improve disabling of features which have dependencies xen/x86: Improvements to in-hypervisor cpuid sanity checks x86/cpu: Move set_cpumask() calls into c_early_init() x86/cpu: Sysctl and common infrastructure for levelling context switching x86/cpu: Rework AMD masking MSR setup x86/cpu: Rework Intel masking/faulting setup x86/cpu: Context switch cpuid masks and faulting state in context_switch() x86/pv: Provide custom cpumasks for PV domains x86/domctl: Update PV domain cpumasks when setting cpuid policy xen+tools: Export maximum host and guest cpu featuresets via SYSCTL tools/libxc: Modify bitmap operations to take void pointers tools/libxc: Use public/featureset.h for cpuid policy generation tools/libxc: Expose the automatically generated cpu featuremask information tools: Utility for dealing with featuresets tools/libxc: Wire a featureset through to cpuid policy logic tools/libxc: Use featuresets rather than guesswork tools/libxc: Calculate xstate cpuid leaf from guest information .gitignore | 2 + tools/libxc/Makefile | 9 + tools/libxc/include/xenctrl.h | 22 +- tools/libxc/xc_bitops.h | 37 +- tools/libxc/xc_cpufeature.h | 151 ------- tools/libxc/xc_cpuid_x86.c | 598 +++++++++++++++++----------- tools/libxl/libxl_cpuid.c | 2 +- tools/misc/Makefile | 4 + tools/misc/xen-cpuid.c | 394 ++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 3 + tools/ocaml/libs/xc/xenctrl.mli | 4 + tools/ocaml/libs/xc/xenctrl_stubs.c | 37 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- xen/arch/x86/Makefile | 1 + xen/arch/x86/acpi/cpu_idle.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/lib.c | 4 +- xen/arch/x86/apic.c | 2 +- xen/arch/x86/cpu/amd.c | 310 ++++++++------ xen/arch/x86/cpu/common.c | 54 ++- xen/arch/x86/cpu/intel.c | 263 +++++++----- xen/arch/x86/cpu/mcheck/mce_intel.c | 2 +- xen/arch/x86/cpu/mwait-idle.c | 2 +- xen/arch/x86/cpuid.c | 236 +++++++++++ xen/arch/x86/crash.c | 3 + xen/arch/x86/domain.c | 20 +- xen/arch/x86/domctl.c | 124 ++++++ xen/arch/x86/hvm/hvm.c | 95 ++--- xen/arch/x86/hvm/vmx/vmcs.c | 4 +- xen/arch/x86/hvm/vmx/vvmx.c | 6 +- xen/arch/x86/microcode_intel.c | 3 +- xen/arch/x86/psr.c | 4 +- xen/arch/x86/setup.c | 3 + xen/arch/x86/smpboot.c | 46 --- xen/arch/x86/sysctl.c | 57 +++ xen/arch/x86/traps.c | 169 ++++---- xen/arch/x86/xstate.c | 6 +- xen/include/Makefile | 10 + xen/include/asm-x86/amd.h | 4 +- xen/include/asm-x86/cpufeature.h | 175 +------- xen/include/asm-x86/cpufeatureset.h | 22 + xen/include/asm-x86/cpuid.h | 45 +++ xen/include/asm-x86/domain.h | 2 + xen/include/asm-x86/processor.h | 33 +- xen/include/public/arch-x86/cpufeatureset.h | 257 ++++++++++++ xen/include/public/sysctl.h | 50 +++ xen/tools/gen-cpuid.py | 401 +++++++++++++++++++ 47 files changed, 2698 insertions(+), 984 deletions(-) delete mode 100644 tools/libxc/xc_cpufeature.h create mode 100644 tools/misc/xen-cpuid.c create mode 100644 xen/arch/x86/cpuid.c create mode 100644 xen/include/asm-x86/cpufeatureset.h create mode 100644 xen/include/asm-x86/cpuid.h create mode 100644 xen/include/public/arch-x86/cpufeatureset.h create mode 100755 xen/tools/gen-cpuid.py -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |