[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [GRUB2 PATCH v4 1/4] i386/relocator: Add grub_relocator64_efi relocator
- To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- From: "Vladimir 'phcoder' Serbinenko" <phcoder@xxxxxxxxx>
- Date: Tue, 15 Mar 2016 17:00:33 +0100
- Cc: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "grub-devel@xxxxxxx" <grub-devel@xxxxxxx>, "eric.snowberg@xxxxxxxxxx" <eric.snowberg@xxxxxxxxxx>, "arvidjaar@xxxxxxxxx" <arvidjaar@xxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "cardoe@xxxxxxxxxx" <cardoe@xxxxxxxxxx>, "pgnet.dev@xxxxxxxxx" <pgnet.dev@xxxxxxxxx>, "roy.franz@xxxxxxxxxx" <roy.franz@xxxxxxxxxx>, "ning.sun@xxxxxxxxx" <ning.sun@xxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "stefano.stabellini@xxxxxxxxxxxxx" <stefano.stabellini@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "qiaowei.ren@xxxxxxxxx" <qiaowei.ren@xxxxxxxxx>, "richard.l.maliszewski@xxxxxxxxx" <richard.l.maliszewski@xxxxxxxxx>, "gang.wei@xxxxxxxxx" <gang.wei@xxxxxxxxx>, "fu.wei@xxxxxxxxxx" <fu.wei@xxxxxxxxxx>, "seth.goldberg@xxxxxxxxxx" <seth.goldberg@xxxxxxxxxx>
- Delivery-date: Tue, 15 Mar 2016 16:00:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Other than 2 typos (inline). Looks good. Let's give it a day if somebody wants to object, then I'll commit it
movq %rax, %rsp
+ /*
+ * Here is grub_relocator64_efi_start() entry point.
+ * Following code is shared between grub_relocator64_efi_start()
+ * and grub_relocator64_start().
+ *
+ * Think twice before changing anything below!!!
+ */
above? + /* Here grub_relocator64_efi_start() ends. Ufff... */
+VARIABLE(grub_relocator64_efi_end)
+
Probably without _start. Comment probably applies even more here than above. Are you ok with me moving ends to the same place when comitting? This would make the code less error-prone.
--
Regards
Vladimir 'phcoder' Serbinenko
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
