Re: [Xen-devel] [PATCH] docs: update FLASK cmd line instructions

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 3/15/16 3:24 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote:
>> The command line instructions for FLASK include a note on how to compile
>> Xen with FLASK but the note was out of date after the change to Kconfig.
>>
>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>> ---
>> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>> CC: Keir Fraser <keir@xxxxxxx>
>> CC: Tim Deegan <tim@xxxxxxx>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> CC: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
>>
>> Not sure if you want backticks around `make -C menuconfig`. I also figured
>> we should route people towards menuconfig by default. The committer of
>> this patch is welcome to change the wording or style in anyway they see
>> fit.
>>
>> ---
>>  docs/misc/xen-command-line.markdown | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/misc/xen-command-line.markdown 
>> b/docs/misc/xen-command-line.markdown
>> index ca77e3b..949e210 100644
>> --- a/docs/misc/xen-command-line.markdown
>> +++ b/docs/misc/xen-command-line.markdown
>> @@ -665,8 +665,8 @@ to use the default.
>>  > Default: `permissive`
>>  
>>  Specify how the FLASK security server should be configured.  This option is 
>> only
>> -available if the hypervisor was compiled with XSM support (which can be 
>> enabled
>> -by setting XSM\_ENABLE = y in .config).
>> +available if the hypervisor was compiled with FLASK support.  This can be
>> +enabled by running make -C xen menuconfig and enabling XSM and FLASK.
> 
> Would it be better said:
> 
> .. "and enabling Common Features|Xen Security Module support (FLux Advanced 
> Security
> Kernel support gets enabled automatically)."
> ?

My response falls in the bucket of a tristate boolean. It depends on how
you want to document these values. By the pretty strings or the
searchable names. And then making sure all the doc places are consistent
with that.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel