Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob ...

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Mar 16, 2016 at 09:54:44AM +0100, Dario Faggioli wrote:
> On Tue, 2016-03-15 at 20:26 -0400, Konrad Rzeszutek Wilk wrote:
> > On Mon, Mar 14, 2016 at 05:55:39PM +0000, Anthony PERARD wrote:
> > > 
> > > diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> > > index 6cc86ce..6a37758 100644
> > > --- a/tools/firmware/Makefile
> > > +++ b/tools/firmware/Makefile
> > > @@ -19,6 +19,9 @@ SUBDIRS-y += hvmloader
> > >  
> > >  LD32BIT-$(CONFIG_FreeBSD) := LD32BIT_FLAG=-melf_i386_fbsd
> > >  
> > > +SEABIOS_ROM := seabios-dir/out/bios.bin
> > > +OVMF_ROM := ovmf-dir/ovmf.bin
> > These will set the variables..
> > > 
> > > +
> > >  ovmf-dir:
> > >   GIT=$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh
> > > $(OVMF_UPSTREAM_URL) $(OVMF_UPSTREAM_REVISION) ovmf-dir
> > >   cp ovmf-makefile ovmf-dir/Makefile;
> > > @@ -45,6 +48,16 @@ endif
> > >  install: all
> > >   [ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR)
> > >   [ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET)
> > > $(INST_DIR)
> > > +ifeq ($(CONFIG_SEABIOS),y)
> > > +ifeq ($(SEABIOS_PATH),)
> > But here you check them?
> > 
> > Or should the setting of OVMF_ROM and SEABIOS_ROM be ?= 
> > 
> I don't speak too much Makefile, TBH (so apologies if I'm talking
> nonsense), but it looks to me that what is set above and what is
> checked here are indeed _not_the_same_ variables.. isn't that the case?

<facepalm>
You are right.

Ignore my comment.

Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel