[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.



>>> On 15.03.16 at 18:56, <konrad.wilk@xxxxxxxxxx> wrote:
> It is not used.

Consistently please - either keep them all (just to cover the case
that they might get used) or remove them all: xen_compile_info,
xen_changeset_info, etc are all unused too. Otoh
xennmi_callback is used, but xennmi_callback_t isn't. Which to me
suggests that we should leave this alone.

Jan

> --- a/xen/common/compat/kernel.c
> +++ b/xen/common/compat/kernel.c
> @@ -18,7 +18,6 @@ asm(".file \"" __FILE__ "\"");
>  
>  extern xen_commandline_t saved_cmdline;
>  
> -#define xen_extraversion compat_extraversion
>  #define xen_extraversion_t compat_extraversion_t
>  
>  #define xen_compile_info compat_compile_info
> -- 
> 2.5.0




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.