Re: [Xen-devel] [PATCH v2] x86/hvm/viridian: fix the TLB flush hypercall

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.16 at 15:21, <paul.durrant@xxxxxxxxxx> wrote:
> v2:
>  - Move to per-pcpu ipi mask.
>  - Use smp_send_event_check_mask() to IPI rather than flush_tlb_mask().
> ---
>  xen/arch/x86/hvm/hvm.c             | 12 ------------
>  xen/arch/x86/hvm/viridian.c        | 19 ++++++-------------
>  xen/include/asm-x86/hvm/viridian.h |  4 ----
>  3 files changed, 6 insertions(+), 29 deletions(-)

Quite nice for a bug fix.

> @@ -656,7 +647,9 @@ int viridian_hypercall(struct cpu_user_regs *regs)
>           * so we may unnecessarily IPI some CPUs.
>           */
>          if ( !cpumask_empty(pcpu_mask) )
> -            flush_tlb_mask(pcpu_mask);
> +            smp_send_event_check_mask(pcpu_mask);
> +
> +        output.rep_complete = input.rep_count;

Questions on this one remain: Why only for this hypercall? And
what does "repeat count" mean in this context?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel