Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 16/03/16 16:58, Ian Jackson wrote:
> George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a 
> funciton"):
>> From: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>>
>> Move pygrub checks for local access ability into a separate function.
>>
>> Also reorganize libxl__device_disk_local_initiate_attach so that we
>> don't initialize dls->disk unless we actually end up doing a local
>> attach.
> ...
>> +static char * libxl__device_disk_find_local_path(libxl__gc *gc, 
>> +                                                 const libxl_device_disk 
>> *disk) {
>                 ^ whitespace

Oops..


>     ^ line length

I was about to say "it's nto clear to me how to make this shorter", but
then I could just not have the const align with the '(', couldn't I?

There's a line in another patch that has a similar problem / solution.

> I think I need to review this with `git diff -b' - can you give me a
> git branch for your series or shall I git-am it ?

I'm actually rather in the middle of some further work (I'm trying to
get the script to fail on a duplicate block device) -- would you mind
running git am?

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel