[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.



Hi Konrad

On 16/03/2016 17:52, Konrad Rzeszutek Wilk wrote:
On Wed, Mar 16, 2016 at 05:32:09PM +0000, Julien Grall wrote:
Sorry for the late answer on this patch. I noticed the problem while I was
reviewing your xSplice patch series.

On 12/02/2016 15:56, Konrad Rzeszutek Wilk wrote:
 From 32a062c119091f2f3f6a4c540a8098e97c273dd2 Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Fri, 5 Feb 2016 10:44:45 -0500
Subject: [PATCH] arm/config: Declare ELFSIZE_64.

Otherwise any code that tries to use Elf_* macros would
require us to use Elf64_* types instead of the more
friendly Elf_ one.

This is OK to do since 32-bit ARM uses LPAE mode.

That's not true. Some of structures have a different layout based on the
file class (i.e ELFSIZE in Xen).

For 32-bit ARM, ELFCLASS32 (i.e 32-bit data types) will always be used. So
we need to set ELFSIZE to 32.

OK. Let me send out a patch to fix that. Thanks for the heads up!

With this change, do you need to revise the answer to the question Jan raised in the design document about ARM32 and the ELF payload declaring the ELF only 64-bit syntax?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.