Re: [Xen-devel] [PATCH v4 1/2] x86/hvm/viridian: keep APIC assist page mapped...

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 17 March 2016 11:59
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v4 1/2] x86/hvm/viridian: keep APIC assist page
> mapped...
> 
> >>> On 17.03.16 at 09:37, <paul.durrant@xxxxxxxxxx> wrote:
> > +static void teardown_apic_assist(struct vcpu *v)
> > +{
> > +    struct page_info *page = v->arch.hvm_vcpu.viridian.apic_assist.page;
> > +    void *va = v->arch.hvm_vcpu.viridian.apic_assist.va;
> >
> > +    if ( !va )
> > +        return;
> > +
> > +    v->arch.hvm_vcpu.viridian.apic_assist.va = NULL;
> > +    v->arch.hvm_vcpu.viridian.apic_assist.page = NULL;
> > +
> > +    unmap_domain_page_global(va);
> >      put_page_and_type(page);
> >  }
> 
> The apic_assist.page field is needed only here, and is redundant
> with the va being stored (from which it can be derived via
> domain_page_map_to_mfn()). Please let's avoid needlessly
> growing struct vcpu.
> 

Ok. I'll drop it then.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel