[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11 19/27] COLO: introduce new API to prepare/start/do/get_error/stop replication
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
- From: Changlong Xie <xiecl.fnst@xxxxxxxxxxxxxx>
- Date: Fri, 18 Mar 2016 11:45:00 +0800
- Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jiang Yunhong <yunhong.jiang@xxxxxxxxx>, Dong Eddie <eddie.dong@xxxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx>, Shriram Rajagopalan <rshriram@xxxxxxxxx>, Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
- Delivery-date: Fri, 18 Mar 2016 03:42:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 03/05/2016 01:26 AM, Ian Jackson wrote:
Changlong Xie writes ("[PATCH v11 19/27] COLO: introduce new API to
prepare/start/do/get_error/stop replication"):
From: Wen Congyang <wency@xxxxxxxxxxxxxx>
We will use qemu block replication, and qemu provides some qmp commands
to prepare replication, start replication, get replication error, and
stop replication. Introduce new API to execute these qmp commands.
How will this work if in future we want to support HVM (or
hvm-lite-ng) guests ?
Sorry for bad english, what does "hvm-lite-ng" mean? I can't figure out
this abbr.
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 5160939..8cb9f19 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1771,6 +1771,26 @@ _hidden int
libxl__qmp_set_global_dirty_log(libxl__gc ...
+_hidden int libxl__qmp_nbd_server_add(libxl__gc *gc, int domid, const char
*disk);
It's a tiny nit, but can I grumble about the long lines here ? Less
than ~70-75 characters is best.
Surely
Thanks
-Xie
Thanks,
Ian.
.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
