Re: [Xen-devel] [PATCH v6 09/22] arm/p2m: Add helper functions to map memory regions

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shannon,

On 22/03/16 13:05, Shannon Zhao wrote:
> On 2016年03月21日 23:52, Julien Grall wrote:
> > Title: to map/unmap
> >
> > On 17/03/2016 09:40, Shannon Zhao wrote:
> > > diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> > > index 433952a..17be6ad 100644
> > > --- a/xen/include/asm-arm/p2m.h
> > > +++ b/xen/include/asm-arm/p2m.h
> > > @@ -144,6 +144,16 @@ int p2m_cache_flush(struct domain *d, xen_pfn_t
> > > start_mfn, xen_pfn_t end_mfn);
> > >    /* Setup p2m RAM mapping for domain d from start-end. */
> > >    int p2m_populate_ram(struct domain *d, paddr_t start, paddr_t end);
> > >
> > > +int map_regions_rw(struct domain *d,
> > > +                    unsigned long start_gfn,
> > > +                    unsigned long nr_mfns,
> > > +                    unsigned long mfn);
> >  From the commit message, this function will map the region read-write
> > and cacheable.
> >
> > But it's not clear from the name. Please either rename the function or
> > document it in the code.
> So map_regions_rw_cache?
It sounds good.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel