[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface



On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> Will change to "Prevent the OS from initializing the PAT MSR".
> 
> I wanted to clarify that "disable" does not mean to disable PAT MSR.

How do you "disable PAT MSR" ?

I think you're overdocumenting this. pat_disable() is as clear as day
what it does. It doesn't need any commenting...

> I've run checkpatch.pl and thought it was OK to have this warning (instead
> of a >80 warning) since the error message part was not split.  The
> "attempting" part is for debugging and its string is passed from the
> caller. 

We always put the quoted strings on a single line for easier grepping.
Forget the 80-cols rule.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 
(AG Nürnberg)
-- 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.