[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] blkif.h: document scsi/0x12/0x<NN> node

Paul Durrant writes ("RE: [PATCH] blkif.h: document scsi/0x12/0x<NN> node"):
> > From: Bob Liu [mailto:bob.liu@xxxxxxxxxx]
> > Sent: 23 March 2016 11:48
> > To: xen-devel@xxxxxxxxxxxxx
> > Cc: Paul Durrant; Ian Jackson; konrad.wilk@xxxxxxxxxx; jgross@xxxxxxxx;
> > Roger Pau Monne; annie.li@xxxxxxxxxx; David Vrabel; Bob Liu
> > Subject: [PATCH] blkif.h: document scsi/0x12/0x<NN> node

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I'm sorry to say that the need for this protocol extension, and its
proper semantics, have yet to be established.

I don't think it was appropriate to repost the patch in this form
while the conversation on those topics is ongoing.  It would have been
appropriate if the patch contained answers, or at least forward
movement, in that conversation.  But regret to say that this version
of this patch does not do that.

> > + * The data of this string node is base64 encoded. Base64 is a group of
> > + * similar binary-to-text encoding schemes that represent binary data in
> > an
> > + * ASCII string format by translating it into a radix-64 representation.
> Do we need to explain what base64 is?

This seems to be a response to my complaint

  I would like the base64 encoding to specified much more explicitly.
  Just `base64 formatted' is too vague.

By that I meant that the specific exact base64 format (of which there
are of course several dialects each with various variants) has to be
specified, probably by an reference to a suitable external

I did not mean that a general dictionary definition of base64 should
be cut-and-pasted from Wikipedia into this specification document.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.