[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v8 0/3] VT-d Device-TLB flush issue



This patches fix current timeout concern and also allow limited ATS support:

1. Reduce spin timeout to 1ms, which can be boot-time changed with 
'vtd_qi_timeout'.
   For example:
           multiboot /boot/xen.gz ... vtd_qi_timeout=100 ...

2. Wrap a _sync version for all VT-d flush interfaces.

    For consistency, we wrap a _sync version for all VT-d flush interfaces.
    It simplifies caller logic and makes code more readable as well.

3. Fix vt-d Device-TLB flush timeout issue.
   If Device-TLB flush timed out, we would hide the target ATS
   device and crash the domain owning this ATS device. If impacted
   domain is hardware domain, just throw out a warning.

   The hidden device should be disallowed to be further assigned
   to any domain.

**NOTE**
   This patch set should base on 2 prereq patch sets:
    a). Make the pcidevs_lock a recursive one.
    b). Check VT-d Device-TLB flush error.

----
Not covered in this series:

    a) Eliminate the panic() in IOMMU_WAIT_OP, used only in VT-d register 
read/write.
       Further discussion is required on whether and how to improve it.
    b) Handle IOTLB/Context/IEC flush timeout.

--Changes in v8:
  *Rebase against a6f2cdb633bf519244a16674031b8034b581ba7f.
#patch 1
  *Add __must_check annotation.   
#patch 2
  *It is a new patch that wraps a _sync version for all VT-d flush interfaces.
#patch 3
  *Add a blank line between:
        +    pcidevs_lock();
        +    for_each_pdev(d, pdev)

Quan Xu (3):
  VT-d: Reduce spin timeout to 1ms, which can be boot-time changed
  VT-d: Wrap a _sync version for all VT-d flush interfaces
  VT-d: Fix vt-d Device-TLB flush timeout issue

 docs/misc/xen-command-line.markdown   |   7 ++
 xen/drivers/passthrough/pci.c         |   6 +-
 xen/drivers/passthrough/vtd/extern.h  |   3 +
 xen/drivers/passthrough/vtd/qinval.c  | 202 ++++++++++++++++++++++++----------
 xen/drivers/passthrough/vtd/x86/ats.c |  15 +--
 xen/include/xen/pci.h                 |   1 +
 6 files changed, 165 insertions(+), 69 deletions(-)

-- 
1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.