Re: [Xen-devel] [PATCH v12 23/26] COLO nic: implement COLO nic subkind

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Changlong Xie writes ("[PATCH v12 23/26] COLO nic: implement COLO nic subkind"):
> From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> 
> implement COLO nic subkind.
...
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index a206d68..a8be078 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -599,6 +599,9 @@ libxl_device_nic = Struct("device_nic", [
>      ("rate_bytes_per_interval", uint64),
>      ("rate_interval_usecs", uint32),
>      ("gatewaydev", string),
> +    # forward device that only used in COLO, it forwards
> +    # the network requests from client to secondary vm
> +    ("forwarddev", string)

Sorry I didn't ask for this last time, but I think this parameter
ought to have `colo' or `coloft' in its name somewhere.

How about `coloft_forwarddev' ?

This is not critical for 4.7 if we aren't trying to provide a stable
API.  Please make sure a copy of the API stability warning text I
mentioned earlier (either because the previous patch put it here, or
adding it to this patch).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel