Re: [Xen-devel] [PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 04/01/16 17:28, Ian Jackson wrote:
> George Dunlap writes ("[PATCH v4 1/5] libxl: Remove pointless hypercall from 
> libxl_set_memory_target"):
>> There's no obvious reason for the call to xc_domain_getinfolist -- all
>> it seems to be doing is checking that the domain exists; but if it
>> doesn't exist, it will have already failed by this point.
>>
>> NB that this will change the return value for libxl_set_memory_target:
>> now it will return 0 on success, rather than returning 1 (which was
>> the previous behavior).  This is more in line with expected behavior,
>> and also allows the caller to distingiush between success and other
>> failure modes (some of which also return 1).
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although I don't see the other return paths returning 1 which you
> mention.

rc is initialized to 1, and there are a number of exit paths (I count 7)
which jump to out without setting it; including setting the target above
static_max.

BTW I'm about to re-send the Ack'ed patches in this series (rebased to
staging).

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel