[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

On 03/25/2016 11:33 AM, Samuel Thibault wrote:
> Wei Liu, on Fri 25 Mar 2016 13:09:07 +0000, wrote:
>> CC Samuel
> Thanks.
>> On Wed, Mar 23, 2016 at 02:26:51PM -0700, Sarah Newman wrote:
>>> 7c8f3483 introduced a break within a loop in netfront.c such that
>>> cons and nr_consumed were no longer always being incremented. The
>>> offset at cons will be processed multiple times with the break in
>>> place.
>>> Remove the break and re-add "some !=0" in the loop for HAVE_LIBC.
> Mmm, right.
> That ifdef makes things even more difficult to understand then. That
> however makes me think: how about the attached patch, which actually
> simplifies the rest.
> Thanks!
> Samuel

I have no objections to backing out additional changes made in 7c8f3483, but I 
wasn't the person who submitted that patch.

The patch tests OK with GNT_DEBUG enabled.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.