Re: [Xen-devel] [PATCH v4 19/26] xen+tools: Export maximum host and guest cpu featuresets via SYSCTL

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Mar 23, 2016 at 04:36:22PM +0000, Andrew Cooper wrote:
> And provide stubs for toolstack use.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: David Scott <dave@xxxxxxxxxx>
> Acked-by: Jan Beulich <JBeulich@xxxxxxxx>
> ---
> CC: Tim Deegan <tim@xxxxxxx>

You should also CC Daniel De Graaf..
> 
> v2:
>  * Rebased to use libxencall
>  * Improve hypercall documentation
> v3:
>  * Provide libxc implementation for XEN_SYSCTL_get_cpu_levelling_caps as well.
> v4:
>  * More const.
> ---
>  tools/libxc/include/xenctrl.h       |  4 +++
>  tools/libxc/xc_cpuid_x86.c          | 41 +++++++++++++++++++++++++++++
>  tools/ocaml/libs/xc/xenctrl.ml      |  3 +++
>  tools/ocaml/libs/xc/xenctrl.mli     |  4 +++
>  tools/ocaml/libs/xc/xenctrl_stubs.c | 35 +++++++++++++++++++++++++
>  xen/arch/x86/sysctl.c               | 51 
> +++++++++++++++++++++++++++++++++++++
>  xen/include/public/sysctl.h         | 27 ++++++++++++++++++++

And implement the XSM flask sub-ops including the appropiate xen.te policy
modification along with updating the attributes file.

Otherwise the code looks good and you can tack on Reviewed-by: Konrad Rzeszutek
Wilk <konrad.wilk@xxxxxxxxxx>. Or wait until you repost it with the XSM checks 
and
I can extend the 'Reviewed-by' for the XSM code..

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel