Re: [Xen-devel] [PATCH v3] xen/arm64: check XSM Magic and Signature from the second unknown module.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.03.16 at 05:26, <fu.wei@xxxxxxxxxx> wrote:
> +static bool __init check_xsm_signature(const void *fdt, int node,
> +                                       const char *name,
> +                                       u32 address_cells, u32 size_cells)
> +{
> +#ifdef CONFIG_FLASK
> +    u32 xen_magic = XSM_MAGIC, target_len = 8;
> +    const struct fdt_property *prop;
> +    unsigned char buff[16];
> +    paddr_t start, size;
> +    const __be32 *cell;
> +    int len;
> +
> +    prop = fdt_get_property(fdt, node, "reg", &len);
> +    if ( !prop || len < dt_cells_to_size(address_cells + size_cells))

At the very least you'll need to adjust style: There's a missing
blank before the closing parenthesis here, and more of this kind
of issue follow later.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel