Re: [Xen-devel] [PATCH 00/11] Return failure on failure for more xl commands

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 30, 2016 at 05:02:39PM +0200, Paulina Szubarczyk wrote:
> This patch includes the changes from a patch prepared by George Dunlap
> [0] and expands them to more xl commands.
> 

Hello,

Did you perhaps make a mistake? As far as I can tell some patches were
already applied. Don't worry, we all make mistakes from time to time.

I realise you might be looking at master branch. Please check staging
branch to see if you should drop some of the already patches.

And perhaps can you indicate which patches should we look at in case you
don't want to resend just yet.

Wei.

> This is my bite-sized outreachy project [1][2].
> 
> Return failure when the command failed for more xl commands:
> - mem-set
> - cd-insert
> - pci-*
> -- freemem
> -- tmem-*
> 
> This makes xl more useful for scripting.
> 
> In the case of mem-set, it means first cleaning up
> libxl_set_memory_target() to return useful error codes.
> 
> For pci-* functions libxl__create_pci_backend(), 
> libxl__device_pci_destroy_all()
> return error codes instead of always 0.
> 
> Changes:
> - Remove block-attach patch
> - Split out removal of spurious getinfolist to a separate patch
> - Try to follow CODING_STYLE more closely:
>  - In general, don't initialize rc / r, but use set-and-goto
>  - Use 'r' for non-libxl error codes
>  - Use EXIT_FAILURE and EXIT_SUCCESS rather than magic constants in main_foo()
>  - Use 1 and 0 in internal functions of xl
> 
> [0] http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02246.html
> [1] http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg03031.html
> [2] https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxx/msg62055.html
> 
> CC:   Wei Liu <wei.liu2@xxxxxxxxxx>
> CC:   Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel