Re: [Xen-devel] [PATCH v10 4/5] libxl: add support for vscsi

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Mar 31, Juergen Gross wrote:

> On 22/03/16 09:23, Olaf Hering wrote:

> > +#define COMPARE_VSCSI(a, b) ((a)->devid == (b)->devid)
> Is this really needed? I'd prefer using COMPARE_DEVID() instead.

COMPARE_VSCSI used to do something else in an earlier variant.
Now COMPARE_DEVID can be used.

> > +        if (sscanf(p, "naa.%16c:%llu", wwn, &lun) == 2 && 
> > vscsi_wwn_valid(wwn)) {
> Or even: omit the whole function and use "%16[0-9a-fA-F]" as format of
> sscanf().

Yes, thanks for the feedback. I will change it.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel