Re: [Xen-devel] [PATCH] xen/arm: make the error log printk ratelimited

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2016/3/31 17:12, Jan Beulich wrote:
>>>> On 31.03.16 at 11:05, <zhaoshenglong@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/arm/p2m.c
>> > +++ b/xen/arch/arm/p2m.c
>> > @@ -1284,8 +1284,9 @@ int map_dev_mmio_region(struct domain *d,
>> >      res = map_mmio_regions(d, start_gfn, nr, mfn);
>> >      if ( res < 0 )
>> >      {
>> > -        printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
>> > -               start_gfn, start_gfn + nr - 1, d->domain_id);
>> > +        if ( printk_ratelimit() )
>> > +            printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
>> > +                   start_gfn, start_gfn + nr - 1, d->domain_id);
>> >          return res;
>> >      }
> I think this would better simply use XENLOG_G_ERR.
Ok, will update.

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel